Image smoothing as a setting#138
Conversation
a setting. This is global, meaning it adjusts smoothing of ALL images, but inefficient. Other possible approaches are to index through asset library (same outcome) and to add two settings buttons in inspector: enable/disable and apply to all. My opinion is that we should add both options (inspector and global).
…ing on/off operating.
|
Was trying it just now and it seems like the image always reverts back to smoothening after any editor interaction. I'm not too sure myself on whether a global or image-specific setting is better (it's probably worth a full discussion to decide), but I think it should be a project setting rather than an editor setting at the very least. |
I think the issue is that the option just goes child-by-child changing the path's smoothing property, for this to work as intended it must applied to images being created. I would also argue that there isn't any good reason to implement such a difficult thing, There haven't been many pixel art animations/games using Wick, and this just feels like implementing for the sake of implementing. |
|
I can say for myself that I've made one pixel art game semi-recently and one pixel art animation waaaaaay in the past. 1x-resolution pixel art would show up blurry, and while I was able to just solve it by exporting at 10x resolution, I do think that an anti-alias option is helpful. It would mean that you can make your pixel art as zoomed in as you want while still looking crisp. Though thinking about it more, there isn't really a compelling reason to make this an object-specific setting, so a project-wide toggle is probably better. This will most likely be a 1.1.0 kind of deal so no there's no rush. |
…g-global-implementation-2-assetlib
|
Do you have any idea where the bug might be? because I have no ideas at all |
|
I'll be busy for a while so I can't look too closely at this for at least a week, and honestly I don't really know off the top of my head either, but I can try tackle it next week. |
…g-global-implementation-2-assetlib
…g-global-implementation-2-assetlib
3 participants
I've added image smoothing as a setting, and it works I think. I have very little experience in testing for bugs, so some may be found. This is also a global feature, meaning that as of now you can't (or aren't supposed to) have image smoothing on for one and off for the rest using the setting. Technically the on/off script only runs if you change the setting, and you can still turn smoothing on/off through code, but it's a bit less likely a use case to me so I left it alone.
I don't know if you want to have smoothing in the inspector or not, but it's a bit harder to do that and the global setting, but I'm working (sadly very slowly) on it. That said, I think this is fine for most use cases.
Also I accidentally put the commits from the other pull I made on this pull, and idk what to do. Merge that one first maybe?
Closes #3