Repository navigation
Conversation
Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedding admission currently carries a Metal-derived estimate into every backend. This adds a context-only measurement API on the already loaded model: the existing memory constructors and graph allocator receive an explicit no-allocation mode, and report host/device buffer placement through a typed callback. No weights are reloaded or mutated. Output growth is included, compute buffers shared by backend types are counted once, and measurement and materialization use the same context parameter validation.
Validation: Windows CPU native build passed; Windows CUDA native build (SM120, CUDA13.2) passed. Rust consumer tests cover mixed-placement budgets, repeated buffer rows and null-model rejection. Real-model comparison is exposed as an explicitly opt-in isolated test in the paired Continuum change and remains pending independent review. No runtime deployment or learning acceptance is claimed.
This patch starts at the installed native pin316ad8b9250d114533e70b846b5ffbb4c7ebd80a. The three later diagnostic commits on the integration branch are preserved and are not part of the proposed consumer pin. Review alongside Continuum card1d8e616b. AI implementation assisted by Codex under Joel's explicit direction.