Skip to content

Add missing generic type for Angular 9#102

Open
bineagu wants to merge 1 commit into
CaliStyle:masterfrom
bineagu:fix-angular9
Open

Add missing generic type for Angular 9#102
bineagu wants to merge 1 commit into
CaliStyle:masterfrom
bineagu:fix-angular9

Conversation

@bineagu

@bineagu bineagu commented Apr 23, 2020

Copy link
Copy Markdown

Summary of changes:
Added the generic type in module declaration to support Angular 9.

Checklist:

  • [X ] npm run build runs without error
  • [X ] ng serve spawns app, Intercom messenger is visible and interactive, and there are no errors in the console

Closes issue: #101

@bineagu

bineagu commented Apr 23, 2020

Copy link
Copy Markdown
Author

Sorry if I did something wrong, this is my first attempt at a pull request :)

@scott-wyatt

Copy link
Copy Markdown
Member

Thanks for the PR! 🎈🎈🎈I’ll take a look at soon as I can.

@wbhob

wbhob commented Apr 25, 2020

Copy link
Copy Markdown
Contributor

This looks good, except you're also going to want to upgrade @angular/* in devDependencies (so that it compiles with latest angular) and in peerDependencies (so that consumers don't get type collisions with Angular 8-). Thanks for the PR!

@egd-flaine

Copy link
Copy Markdown

Hello,
What's the status? Waiting for this merge : )
Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants