Skip to content

Resolve Gumbo from JitPack instead of a hand-built local install #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
contrasam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolve Gumbo from JitPack instead of a hand-built local install #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion catalyst-gumbo/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<artifactId>catalyst-events</artifactId>
</dependency>
<dependency>
<groupId>com.cajunsystems</groupId>
<groupId>com.github.CajunSystems</groupId>
<artifactId>gumbo</artifactId>
</dependency>
<dependency>
Expand Down
27 changes: 20 additions & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,27 @@
</properties>

<!--
Gumbo (com.cajunsystems:gumbo:0.3.0) is the durable log backend. The intended delivery was
JitPack, but jitpack.io is blocked by this environment's egress policy, so Gumbo is resolved
from the local Maven repository instead: build it once with
mvn -f /path/to/gumbo/pom.xml install -DskipTests
which installs com.cajunsystems:gumbo:0.3.0 into ~/.m2. Its own dependencies resolve from
Maven Central. No Gumbo source is vendored into this build.
Gumbo is the durable log backend, delivered by JitPack, which builds it from the tag in
the CajunSystems/gumbo repository.

The coordinate is com.github.CajunSystems:gumbo, not the com.cajunsystems:gumbo that
Gumbo's own pom declares. JitPack rewrites the groupId to com.github.{owner} when it
publishes, so the string that resolves depends on where the jar came from: build Gumbo
locally with `mvn install` and it lands in ~/.m2 as com.cajunsystems:gumbo; fetch the
same jar from JitPack and it is com.github.CajunSystems:gumbo. This build uses the
JitPack one, so it resolves on any machine with network access rather than only on one
where Gumbo has been built by hand.

No Gumbo source is vendored into this build; its own dependencies resolve from Central.
-->

<repositories>
<repository>
<id>jitpack.io</id>
<url>https://jitpack.io</url>
</repository>
</repositories>

<dependencyManagement>
<dependencies>
<!-- Internal modules -->
Expand Down Expand Up @@ -135,7 +148,7 @@
<version>${bytebuddy.version}</version>
</dependency>
<dependency>
<groupId>com.cajunsystems</groupId>
<groupId>com.github.CajunSystems</groupId>

@greptile-apps greptile-apps Bot Jul 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Local fallback uses wrong coordinate

When jitpack.io is blocked and a developer follows the documented local-install fallback, Gumbo is installed as com.cajunsystems:gumbo while this dependency now requests com.github.CajunSystems:gumbo, causing Maven dependency resolution and the build to fail.

<artifactId>gumbo</artifactId>
<version>${gumbo.version}</version>
<exclusions>
Expand Down
Loading