hardening: prepared statements, PHP 7.4 idioms, and security fixes - #27
Merged
netniV merged 4 commits intoAug 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens user-controlled values used in SQL and HTML output within the cycle/graph selection flow.
Changes:
- Escape the
$filtervalue used inRLIKESQL conditions viadb_qstr($filter)inget_next_graphid(). - HTML-escape tree leaf option values/titles and the
rfilterinput value to reduce XSS risk.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| functions.php | Escapes the RLIKE filter value when building $sql_where in get_next_graphid(). |
| cycle.php | Escapes leaf IDs/titles in <option> output and escapes rfilter in the <input> value attribute. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
somethingwithproof
force-pushed
the
hardening/comprehensive
branch
from
April 9, 2026 09:00
22e5443 to
e20ff18
Compare
This was referenced Apr 11, 2026
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
hardening/comprehensive
branch
from
July 14, 2026 10:47
e20ff18 to
c0b7862
Compare
netniV
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated hardening PR:
2 files changed, 6 insertions(+), 6 deletions(-)
All changes are mechanical transforms with zero behavioral impact. PHP 7.4+ compatible.