Skip to content

feat(pickup): 홈 전역 픽업 날짜/시간 슬롯 (pickupCalendar/pickupTimeSlots)#147

Merged
chanwoo7 merged 1 commit into
developfrom
feat/pickup-slots
Jun 17, 2026
Merged

feat(pickup): 홈 전역 픽업 날짜/시간 슬롯 (pickupCalendar/pickupTimeSlots)#147
chanwoo7 merged 1 commit into
developfrom
feat/pickup-slots

Conversation

@chanwoo7

Copy link
Copy Markdown
Member

Summary

홈 화면의 픽업 날짜/시간 선택(화면 05) 백엔드인 PR4입니다. 월별 달력과 시간 슬롯을 제공하는 pickupCalendar / pickupTimeSlots 쿼리를 신설했습니다.

합의대로 홈 전역 슬롯(매장 무관 고정 정책) 방식이라 스키마 변경·의존성 추가가 없습니다.

Scope

  • pickup feature 신설(public query): pickupCalendar(yearMonth) / pickupTimeSlots(date)
    • 달력: KST 기준 과거(PAST)·최대일수(+30일) 초과(OUT_OF_RANGE) 선택 불가 판정
    • 시간 슬롯: 10:00~20:00 / 30분 간격, 오전·오후 구분, 당일은 현재시각+리드타임(60분) 이전 마감
  • KST 시간 유틸 신설(common/utils/kst-time.ts): KST(UTC+9) 날짜/시간 분해·파싱·일수차·자정 변환 순수 함수. now 주입으로 결정적 테스트
  • 전역 정책 상수(pickup.constants.ts): 영업/간격/최대일수/리드타임. 기획 확정 시 교체
  • 테스트 23개: KST 경계(UTC 15:00=KST 익일), 달력 PAST/OUT_OF_RANGE, 슬롯 미래/당일컷오프/과거/범위초과, 형식 오류 BadRequest

진행 상황

전체 4개 PR 중 4번째(마지막):

Impact

  • DB: 스키마 변경 없음(전역 고정 정책).
  • API: public query 2종 신규. 기존 변경 없음.
  • 의존성: 추가 없음. KST 유틸은 향후 다른 시간 도메인에서 재사용 가능.

Test plan

  • yarn validate 전체 통과 — 159 suites / 1342 tests / 커버리지 임계 충족
  • pickup/KST 신규 23개(상기 Scope)

한계 / 후속 (명시)

  • 전역 슬롯은 달력 UX·검색조건 제공용으로, 매장별 영업시간·capacity·휴무는 반영하지 않습니다. 실제 픽업 가능 여부는 주문 단계에서 매장 정책으로 별도 검증(현 order 도메인, 후속).
  • 위치 표기 규칙, 랭킹 캐시/배치 최적화, 매장 상세 화면, nearbyRegions(현재위치 좌표) 등은 앞선 PR들에서 이월된 후속 항목.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c63da13a-b182-4cdf-a0e3-5351b02bfa30

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pickup-slots

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

요약 항목 없음
전체 리포트
(knip 출력 없음 — 이슈 0이거나 실행 실패)

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

Copy link
Copy Markdown

🩺 NestJS Doctor — 88/100 (Good)

진단 254건 (error 0).

Category error warning info
architecture 0 0 13
correctness 0 105 0
performance 0 24 16
schema 0 0 83
security 0 13 0
architecture / security 상위 항목
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/conversation/repositories/conversation.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'ConversationRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/order/repositories/order.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'OrderRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/product/repositories/product.repository'.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.87234% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/common/utils/kst-time.ts 95.00% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.41% 3881/3984
🟢 Branches 93.19% 1205/1293
🟢 Functions 94.64% 724/765
🟢 Lines 97.82% 3546/3625

Test suite run success

1342 tests passing in 159 suites.

Report generated by 🧪jest coverage report action from ff3b8ff

@chanwoo7 chanwoo7 merged commit 7d896ef into develop Jun 17, 2026
12 checks passed
@chanwoo7 chanwoo7 deleted the feat/pickup-slots branch June 17, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant