Resolves #24 error when CVE record schema cant be loaded - #34
Merged
ann-linh-mitre merged 3 commits intoAug 27, 2026
Conversation
ann-linh-mitre
changed the title
ann-linh-mitre
requested changes
Aug 27, 2026
ann-linh-mitre
left a comment
ann-linh-mitre
left a comment
Contributor
There was a problem hiding this comment.
Overall, changes looks good. Can you make this one update?
Comment on lines
208
to
210
| return isValid | ||
| ? Diagnostics.success() | ||
| : Diagnostics.failSchemaValidation(validator.errors ?? []); |
Contributor
There was a problem hiding this comment.
These lines should be move to the left by an indent to align with line 206.
ann-linh-mitre
approved these changes
Aug 27, 2026
ann-linh-mitre
deleted the
24-error-when-cve-record-schema-cant-be-loaded
branch
August 27, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.