bench(#369): rock-solid on flaky runners — 3× retry + fewer nodes - #488
Open
emooreatx wants to merge 1 commit into
Open
bench(#369): rock-solid on flaky runners — 3× retry + fewer nodes#488emooreatx wants to merge 1 commit into
emooreatx wants to merge 1 commit into
Conversation
A bench built to measure LOW-RESOURCE FLAKY-LINK behaviour must not itself vanish
from the trend when the CI runner is flaky. Two changes:
- bench.yml `run_bench_tolerant` now RETRIES the bench up to 3× in FRESH processes
(a panicked N+2-node fixture leaks no state across attempts), publishing ONLY a
successful attempt's bencher output. A single green attempt reliably lands the
trend point; all-3-flake stays a WARNING, never a red job (a one-run trend gap).
- N_FLOODERS 8 → 4: a smaller fixture whose loopback discovery reliably completes
within one attempt on a loaded runner, still ample concurrent inbound to feed
the drain past any single flooder link's failure.
Confirmed: the fcc97eb baseline series IS live on gh-pages (both drain modes) — the
earlier "stale page" read was a CDN cache lag, not a publish failure. This makes the
NEXT points land reliably too.
actionlint clean; bench compiles (--no-run).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GnAcwXX2rrKm244PFKWbBs
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bench built to measure low-resource flaky-link behaviour must not itself vanish from the trend when the runner is flaky. Fix:
run_bench_tolerantretries up to 3× in fresh processes — a panicked N+2-node fixture leaks no state across attempts — publishing only a successful attempt's bencher output. One green attempt reliably lands the trend point; all-3-flake stays a warning, never a red job.N_FLOODERS8 → 4 — a smaller fixture whose loopback discovery reliably completes within one attempt on a loaded runner, still ample concurrent inbound to feed the drain past any single flooder failure.Confirmed the fcc97eb baseline series is live on gh-pages (both drain modes) — the earlier "stale page" was a CDN cache lag, not a publish failure. This makes the next points land reliably.
actionlintclean; bench compiles.🤖 Generated with Claude Code
https://claude.ai/code/session_01GnAcwXX2rrKm244PFKWbBs