fix(setup): the wizard was asking the poller gate a question it does not answer

[emooreatx]

Closes #21.

The diagnosis is slightly different from the issue's

The issue reads the 80-line gap between clientMode=NODE and clientMode=AGENT as the wizard finalising on a provisional value, and suggests waiting for the probe.

Waiting alone wouldn't have fixed it. At the first gate line the mode was NODE correctly, and it would have stayed NODE however long we waited — the brain reports setup_required: true, and clientModeFrom demotes an unconfigured brain to NODE (CIRISAgent#1075).

The circularity is named in that arm's own comment

addLlmProvider  503   <- so the user could not configure an escape

This gate exists precisely to stop AGENT-only pollers firing at a
server that cannot answer them

The demotion exists because an unconfigured brain 503s addLlmProvider. And the wizard used that demotion to skip the step that calls addLlmProvider.

brain unconfigured → gate says NODE → wizard drops the AI step → brain stays unconfigured

The fix that stopped the 503s became the reason configuration never happens.

Two different questions

	question	unconfigured brain
clientMode	should agent surfaces and pollers run?	demote — correct, they'd 503
the wizard	is there a brain that needs configuring?	offer the step — that's the point

ModeProbe.brainPresent = folded && reachable, independent of readiness, because readiness must not gate the step that produces readiness. The poller gate is unchanged.

The provisional-value half is real too

setupHasAgent was clientMode?.isAgent ?: false — "not probed yet" became "no brain". SetupViewModel is keyed on it and isFinalSetupStep reads it, so the step list is fixed at composition. Screen.Setup now holds on StartupScreen until the probe answers.

Same distinct-zeroes rule as CapabilityWire's null-versus-empty: could-not-determine must not become a definite answer.

Tested against the log

The exact first gate line from the issue — SETUP / 0 services / folded / reachable / unconfigured / fabric-node. The poller gate still returns NODE there; brainPresent is true at the same instant.

Mutation: let readiness back into brainPresent and the two decisive cases fail.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EGE52kPzjGFiPzGcs63ZC1

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.