SOLVERS: prefer cfdemSolverPimple over cfdemSolverPiso by default - #3
Merged
Merged
Conversation
Pimple runs safely in Piso-equivalent mode (nOuterCorrectors 1) with no performance penalty, is generally more accurate for coupled CFD-DEM, and exposes more features. Piso remains the fallback for installs that don't build Pimple. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
nOuterCorr was the wrong OpenFOAM 10 PIMPLE sub-dict key (verified against source: it's nOuterCorrectors), and it contradicted the correct nOuterCorrectors usage added later in the same cell. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The table's Use-for column describes what each solver is; the default-preference rationale isn't a description, so it belongs in its own specifics section below the table, matching every other solver's pattern. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cfdemSolverPimpleshould be preferred overcfdemSolverPisoeven for laminar/single-outer-corrector cases — it runs safely in Piso-equivalent mode (nOuterCorrectors 1) with no performance penalty, is generally more accurate for coupled CFD-DEM, and exposes more features (turbulence, smoothing models,expCorrDeltaUError) if the case grows into needing them.cfdemSolverPisois now documented as the fallback for installs that don't buildcfdemSolverPimple, with a check (ls $CFDEM_APP_DIR | grep cfdemSolver/which cfdemSolverPimple) for confirming availability before assuming it's present.Test plan