chore(setup): upgrade node dependencies#815
Merged
sakshamarora1 merged 1 commit intoJun 16, 2026
Merged
Conversation
palkerecsenyi
left a comment
palkerecsenyi
left a comment
Member
There was a problem hiding this comment.
Looks good, we will need to do some intense testing in dev/sandbox
| "papaparse": "^5.4.1", | ||
| "path": "^0.12.7", | ||
| "pdfjs-dist": "^4.0", | ||
| "pdfjs-dist": "^5.0", |
Member
There was a problem hiding this comment.
We changed this to v5 in invenio-previewer like 9 months ago. Does this mean we've still been using v4 on CDS since then? If this will mean a major version upgrade of pdfjs we should test it very carefully
Contributor
Author
There was a problem hiding this comment.
Looks like it. We also have to test the PDF js streaming fix
Contributor
There was a problem hiding this comment.
can you first also deploy on dev ? I didn't upgrade the frontend there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.