fix: preserve file version snapshots during version creation#531
Open
zubeydecivelek wants to merge 1 commit into
Open
fix: preserve file version snapshots during version creation#531zubeydecivelek wants to merge 1 commit into
zubeydecivelek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In _versions(), when we build cumulative file snapshots, we are assigning the same versioned_files dictionary to every version:
Because this dictionary keeps getting updated in the next loop iterations, the earlier versions were also reflecting the latest state.
For example, if we have:
we would expect:
But because all versions shared the same dictionary reference, we are getting:
So we are missing previous versions and always keeping the latest file version in the earlier snapshots too.
this one has easy fix:
Second issue: we create the version bucket before checking whether the file should be skipped. For example, if Plot files have versions 3 and 4, but plots are skipped later, we still create record versions 3 and 4. Since no kept files change in those versions, they become duplicate versions.
For example:
If plots are skipped, we probably only want:
But currently we can get: