Fix CAPHI rewrite for stem-final i_y / u_w with no suffix - #172
Open
AbdulmalikDS wants to merge 1 commit into
Open
Fix CAPHI rewrite for stem-final i_y / u_w with no suffix#172AbdulmalikDS wants to merge 1 commit into
AbdulmalikDS wants to merge 1 commit into
Conversation
The '+' was required before the suffix group, so a bare stem ending never matched. Move it inside the optional group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138
rewrite_caphirules 3 and 4 require a+after the stem marker, so the$branch never matches. A stem ending in
i_yoru_wwith no suffix is leftas a short vowel + glide instead of a long vowel:
The rules were right when written (027ec90, 2018): the caphi join always
emitted a
+, even for an empty suffix. d99bbbc (2020) made the join skipempty parts, which removed that trailing
+and silently broke the no-suffixcase.
Moved
\+inside the group, as proposed in the issue. Same change was part of#166, split out here on its own with tests.
Checked against calima-msa-r13: 3,062 stems end in
i_y-/u_w-. Runningthe analyzer on 400 of them (2,679 analyses), the only differences are
_i_y -> _ii(580) and_u_w -> _uu(104). Vowel-suffix forms like قاضِيَكَare unchanged.