Make edge/face z-coordinate calculations dask-compatible - #8

Merged

kjnam merged 8 commits into

mainfrom

BDS-181-edge-face-z-to-dask

Jul 30, 2026

Commits on Jul 20, 2026

Rewrites _calculate_edge_z and _calculate_face_z in _schismgrid.py to use lazy xarray operations instead of eager numpy, making them compatible with dask-backed arrays.
Alexandre Georges
committed
2fbfbad
Add tests for face and edge z-coordinate calculations in test_schismgrid_io.py
Alexandre Georges
committed
a97a800
Removed leftover commented-out implementation

aesgeorges
and
Copilot
authored
24b75ec
Fix return type annotation and docstring for _calculate_face_z
Copilot
authored
91e48d6
Fix return type annotation and docstring for _calculate_edge_z
Copilot
authored
49a8260
Remove .values calls in assign_coords to keep z-coordinates lazy
Copilot
authored
a81aafe
Fix z-coordinate shape order in _assign_z_coords, _calculate_edge_z, and _calculate_face_z functions
Alexandre Georges
committed
36a1e39

Commits on Jul 29, 2026

Fix output shape and indexing for _calculate_face_z and _calculate_edge_z tests
Alexandre Georges
committed
955a178