You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code to resize to the image's resolution was at a bad position and causing some edge cases (again depending on monitor resolution and platform), so I've deliberately unhooked it yesterday after some user on Discord, but it's top priority to fix (I have a much better idea where to place it, just struggling on it)
The video of yours just wasn't automatically resized to 1080x1920, the borders are lack of information, using (...) main -w 1080 -h 1920 (...) should work :)
About a website, I'm quite sure it would be nearly impossible to run the code locally on the user's browser because of Python (and many other factors), if just acessing an url to use it, quite certainly not in real time, but...
I can see a Gradio or Streamlit dashboard working if we run it locally, but it's a lot of bandwidth for only me to code right now, as the architecture needs also better ffmpeg, presets system, caching, reusability, but is the end goal per roadmap
One option is to host myself and make it available, I don't have good spare hardware (a R3 1300X and 1050 ti lol), or cloud host it, but for depthflow the computational costs are significant (hugginface spaces are an alternative, not sure if enough cpu there), and-
-would need mechanisms to detect abuse, subscription status if it's paid, etc. not really my expertise in programming
so, for now I'll keep focusing on the foundations, and if someone's up for making a wrapper on top of current stuff or a beta website I'm up to it!
The code to resize to the image's resolution was at a bad position and causing some edge cases (again depending on monitor resolution and platform), so I've deliberately unhooked it yesterday after some user on Discord, but it's top priority to fix (I have a much better idea where to place it, just struggling on it)
The video of yours just wasn't automatically resized to 1080x1920, the borders are lack of information, using (...) main -w 1080 -h 1920 (...) should work :)
New code is up wih a much better place to have the resolutions calculations!
Now depthflow enforces an aspect ratio to the scene and any resize respects it, so depthflow -i image main -r -o ./video will best-match the input image's aspect ratio to the width and height one sends (1920x1080 by default)
It prioritizes width changes over height, and calculates the other missing component if it's not set, so for example:
shaderflow default --ar 16/9 -w 1280: Calculates h=720 as it's not set
shaderflow default --ar 1: Sets resolution to (1920, 1920) as it prioritizes width and ar=1
shaderflow default --ar 16:9 -w 1920 -h 90: Will use the smallest component of the two, so (160, 90)
All of those transfer to depthflow after the main (args) or just depthflow (args) which implies main, the --ar setting is set by depthflow's input command of the image's ratio
Need to git pull all shaderflow/depthflow/monorepo for the new changes as they interop, maybe a git pull --recurse-submodules --rebase could work
Let me know if it works, and any potential edge case I missed, but so far it's much better than previous solutions
Activity
Tremeschin commentedon Apr 15, 2024
The code to resize to the image's resolution was at a bad position and causing some edge cases (again depending on monitor resolution and platform), so I've deliberately unhooked it yesterday after some user on Discord, but it's top priority to fix (I have a much better idea where to place it, just struggling on it)
The video of yours just wasn't automatically resized to 1080x1920, the borders are lack of information, using
(...) main -w 1080 -h 1920 (...)should work :)Tremeschin commentedon Apr 15, 2024
About a website, I'm quite sure it would be nearly impossible to run the code locally on the user's browser because of Python (and many other factors), if just acessing an url to use it, quite certainly not in real time, but...
I can see a Gradio or Streamlit dashboard working if we run it locally, but it's a lot of bandwidth for only me to code right now, as the architecture needs also better ffmpeg, presets system, caching, reusability, but is the end goal per roadmap
One option is to host myself and make it available, I don't have good spare hardware (a R3 1300X and 1050 ti lol), or cloud host it, but for depthflow the computational costs are significant (hugginface spaces are an alternative, not sure if enough cpu there), and-
-would need mechanisms to detect abuse, subscription status if it's paid, etc. not really my expertise in programming
so, for now I'll keep focusing on the foundations, and if someone's up for making a wrapper on top of current stuff or a beta website I'm up to it!
Tremeschin commentedon Apr 15, 2024
I'm very close to a once and for all fix to this aspect ratio enforcing thing, it's much more stable now
I'm reviewing the code and will test on Windows, in a few hours I'll have it commited (^ if things go right 😓)
Tremeschin commentedon Apr 15, 2024
New code is up wih a much better place to have the resolutions calculations!
Now depthflow enforces an aspect ratio to the scene and any resize respects it, so
depthflow -i image main -r -o ./videowill best-match the input image's aspect ratio to the width and height one sends (1920x1080 by default)It prioritizes width changes over height, and calculates the other missing component if it's not set, so for example:
shaderflow default --ar 16/9 -w 1280: Calculatesh=720as it's not setshaderflow default --ar 1: Sets resolution to(1920, 1920)as it prioritizes width and ar=1shaderflow default --ar 16:9 -w 1920 -h 90: Will use the smallest component of the two, so(160, 90)All of those transfer to depthflow after the
main (args)or justdepthflow (args)which impliesmain, the--arsetting is set by depthflow'sinputcommand of the image's ratioNeed to git pull all shaderflow/depthflow/monorepo for the new changes as they interop, maybe a
git pull --recurse-submodules --rebasecould workLet me know if it works, and any potential edge case I missed, but so far it's much better than previous solutions
onlysharma0852 commentedon Apr 16, 2024
I will try and let you know later.