Prepare the build for .NET 11 (deterministic timestamps, SDK vulnerability check) - #44
Merged
Merged
Conversation
… only) Adds DeterministicTimestamp to the CI property group and CheckSdkVulnerabilities to eng/Common.props. Neither has an effect on the current 10.0.4xx SDK; both take effect with the .NET 11 SDK. Partial port: upstream also edits three Polly.Specs files that were created by App-vNext/Polly@1a80392b (xunit v3) and do not exist in Fences yet. Those edits land with that port, tracked in #34. Upstream: App-vNext/Polly#3225. Refs #28. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial port of App-vNext/Polly@f35bc00d (upstream App-vNext/Polly#3225), from upstream sync #1. Refs #28.
What
Directory.Build.props: adds<DeterministicTimestamp>true</DeterministicTimestamp>to theCI == truegroup. The file is now byte-identical to upstream's.eng/Common.props: adds<CheckSdkVulnerabilities>true</CheckSdkVulnerabilities>.Both are .NET 11 groundwork and have no effect today. SDK 10.0.401 doesn't define
CheckSdkVulnerabilitiesat all. ACI=truepack ofParamore.Fences.Corestamps package entries with the pack time both with and withoutDeterministicTimestamp, so this SDK doesn't act on the property either. Neither property can raise a warning in CI underglobal.json's 10.0.400 SDK.Not ported here
Upstream's commit also edits
ContextDictionarySpecs.cs,PolicyOverloadSmokeSpecs.csandTimeout/TimeoutOverloadSmokeSpecs.csundertest/Polly.Specs. Those files were created upstream by App-vNext/Polly@1a80392b (the xunit v3 migration) and don't exist in Fences yet. Those edits will land with that port, tracked in #34.Checks
dotnet build Fences.slnx -warnaserroris clean both normally and withCI=true.dotnet packsucceeds underCI=true.🤖 Generated with Claude Code