Repository navigation
Conversation
The page says an exception bubbles out of Post after the retries and points to a Fallback method to catch it. A failed send to the broker does not bubble out: Brighter logs it, Post returns and the message stays in the outbox. A failed write to the outbox does throw, as a ChannelFailureException. The page also names CommandProcessor.RETRYPOLICY for that write and that send. Both run in the CommandProcessor.OutboxProducer resilience pipeline, and RETRYPOLICY is marked obsolete. The same name in Deposit and Clear and in Explicit Clear changes too, and Explicit Clear now says that a failed send does not throw.
iancooper
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects what the Outbox Support page says about a failed
Post. This is the smaller direction in issue BrighterCommand/Brighter#4489, "an update to the Post section in line with ADR 0063". It doesn't finish that issue: the failure channel is still being designed in PR BrighterCommand/Brighter#4725.The page told readers that
Postthrows once the retries are used up, and to catch that with aFallbackmethod. That holds for a failed write to the outbox, which throws aChannelFailureException. A failed send to the broker is logged,Postreturns and the message stays in the outbox. ADR 0063-failed-delivery-context says the same for producers that confirm through a callback: "message stays un-dispatched, nothing bubbles, Sweeper still retries". So aFallbackmethod never sees a failed send, and without a sweeper or a resend from your own code nothing sends it again. The Post section now says which failure throws and which does not, and links to the sweeper section.It also named
CommandProcessor.RETRYPOLICYin four places, for the write and the send. Both run in theCommandProcessor.OutboxProducerresilience pipeline, which retries three times with a linear back-off from 50 ms by default, andRETRYPOLICYis marked obsolete. Three of those places now name the pipeline, two of them outside the Post section, in Deposit and Clear and in Explicit Clear, and Explicit Clear now also says that a failed send does not throw. The fourth, theUsePolicycaveat, now talks aboutChannelFailureExceptionand namesUseResiliencePipelinebesideUsePolicy. The Post section also links to the page on registering pipelines.I read this in
OutboxProducerMediatorat the 10.7.0 and 10.8.1 tags and on master. I did not run Brighter for this PR.linkcheckandsymbolcheckreport nothing, andpagelintreports no errors and no warnings for the page. I did not runblockcheck, because this change touches no code block.Two other pages make the same claim about
RETRYPOLICY: the Command Processor Configuration Reference, and the legacy section of How Configuring the Command Processor Works. I left them out to keep this to one page, because the reference section also covers the circuit breaker, which this PR doesn't touch. I can send them in a separate PR if you'd like.