Skip to content

BI-2964: Applied observation filtering and pagination on BrAPI side a… - #566

Merged
jloux-brapi merged 2 commits into
epic/BI-2862from
feature/BI-2964
Oct 15, 2026
Merged

jloux-brapi merged 2 commits into
epic/BI-2862from
feature/BI-2964

Conversation

@humsika

@humsika humsika commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Story: BI-2964
Updated the observation GET flow so filtering by program and study, along with pagination, is performed by BrAPI instead of BI-API. BI-API now sends the requested page and page size to BrAPI and returns BrAPI’s pagination metadata while preserving the existing observation and trait-ID processing.

Dependencies

bi-web: epic/BI-2862
bi-api: feature/BI-2964
brapi-Java-ProdServer: feature/BI-2964

Testing

  • Open Experiments & Observations and select an experiment containing observations.
  • Verify that the observations load successfully.
  • Apply filters and confirm the displayed observations match the selected filters.
  • Navigate between different pages and confirm the correct data loads on each page without errors.
  • Change the page size, if available, and confirm pagination continues to work correctly.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

Comment on lines +213 to +214
observationSearchRequest.setPage(page == null ? 0 : page);
observationSearchRequest.setPageSize(pageSize == null ? 1000 : pageSize);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious why this code existed in the previous implementation, but I am glad you kept the use case working. Should be fine for now unless someone wants something different.

@jloux-brapi
jloux-brapi merged commit b8cd8fd into epic/BI-2862 Oct 15, 2026
1 check failed
@jloux-brapi
jloux-brapi deleted the feature/BI-2964 branch October 15, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants