Repository navigation
BI-2964: Applied observation filtering and pagination on BrAPI side a… - #566
Merged
Merged
Conversation
…nd added Unit tests.
jloux-brapi
approved these changes
Oct 15, 2026
Comment on lines
+213
to
+214
| observationSearchRequest.setPage(page == null ? 0 : page); | ||
| observationSearchRequest.setPageSize(pageSize == null ? 1000 : pageSize); |
Collaborator
There was a problem hiding this comment.
I am curious why this code existed in the previous implementation, but I am glad you kept the use case working. Should be fine for now unless someone wants something different.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2964
Updated the observation GET flow so filtering by program and study, along with pagination, is performed by BrAPI instead of BI-API. BI-API now sends the requested page and page size to BrAPI and returns BrAPI’s pagination metadata while preserving the existing observation and trait-ID processing.
Dependencies
bi-web: epic/BI-2862
bi-api: feature/BI-2964
brapi-Java-ProdServer: feature/BI-2964
Testing
Checklist: