Skip to content

[output] Label the CSV cut list row when no cut list is passed - #597

Open
ChandraChaan wants to merge 2 commits into
Breakthrough:mainfrom
ChandraChaan:fix/csv-cut-list-label
Open

ChandraChaan wants to merge 2 commits into
Breakthrough:mainfrom
ChandraChaan:fix/csv-cut-list-label

Conversation

@ChandraChaan

Copy link
Copy Markdown

write_scene_list() only writes the Timecode List: label when a cut_list is passed. Without one, the conditional expression covers the whole row:

["Timecode List:", *cut_list]
if cut_list
else [start.get_timecode() for start, _ in scene_list[1:]]

so the derived cut list is written with no label, and a single scene gives an empty first row. The CLI always passes a cut list, but API callers relying on the documented default (include_cut_list=True, cut list "generated using the start times of each scene following the first one") get a different first row. write_scene_list_html() already applies the label to both cases.

The label now precedes the cut list whether it is passed or derived. Added test_write_scene_list_cut_list_row_without_cut_list and a changelog entry under 0.7.3.

Verified on my fork:

write_scene_list() only wrote the "Timecode List:" label when a cut_list
was passed. Without one, the conditional expression covered the whole
row, so the derived cut list was written with no label (and an empty
row for a single scene). The CLI always passes a cut list, but API
callers using the documented default got a different first row.

The label now precedes the cut list in both cases, as in
write_scene_list_html().

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants