Repository navigation
[output] Label the CSV cut list row when no cut list is passed - #597
Open
ChandraChaan wants to merge 2 commits into
Open
ChandraChaan wants to merge 2 commits into
ChandraChaan wants to merge 2 commits into
Conversation
write_scene_list() only wrote the "Timecode List:" label when a cut_list was passed. Without one, the conditional expression covered the whole row, so the derived cut list was written with no label (and an empty row for a single scene). The CLI always passes a cut list, but API callers using the documented default got a different first row. The label now precedes the cut list in both cases, as in write_scene_list_html().
MuhammadBilalKhan267
approved these changes
Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_scene_list()only writes theTimecode List:label when acut_listis passed. Without one, the conditional expression covers the whole row:so the derived cut list is written with no label, and a single scene gives an empty first row. The CLI always passes a cut list, but API callers relying on the documented default (
include_cut_list=True, cut list "generated using the start times of each scene following the first one") get a different first row.write_scene_list_html()already applies the label to both cases.The label now precedes the cut list whether it is passed or derived. Added
test_write_scene_list_cut_list_row_without_cut_listand a changelog entry under 0.7.3.Verified on my fork:
main: fails on all 20 build jobs, e.g.AssertionError: assert '00:00:01.000,00:00:02.000' == 'Timecode List:,00:00:01.000,00:00:02.000'(1 failed, 613 passed). https://github.com/ChandraChaan/PySceneDetect/actions/runs/41401693465