Skip to content

fix(app-finder): changes dirs variable to query XDG_DATA_DIRS env va… - #85

Closed
seggsdungeon wants to merge 1 commit into
Brainitech:mainfrom
seggsdungeon:main
Closed

seggsdungeon wants to merge 1 commit into
Brainitech:mainfrom
seggsdungeon:main

Conversation

@seggsdungeon

Copy link
Copy Markdown

fix(app-finder): changes dirs variable to query XDG_DATA_DIRS env variable instead of fixed path

Overview

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to not work as expected)

Testing Checklist

  • I have tested these changes locally and on a fresh VM install.
  • I have tested the QML UI on my primary resolution.
  • (If applicable) I have tested UI changes on secondary monitors or different resolutions.
  • (If applicable) I have verified my bash scripts run cleanly without syntax errors.

Related Issues

@Brainitech Brainitech left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add /usr/share/applications as fallback incase xdg-dir is unset in the users enviroment

@Brainitech

Copy link
Copy Markdown
Owner

Kindly PR to the dev branch

@Brainitech

Copy link
Copy Markdown
Owner

Thanks so much for taking the time to submit this fix!

I actually completely forgot that I recently migrated the App Launcher to use Quickshell's native DesktopEntries module over on the dev branch. Because of that architectural change, list_apps.py is now dead code and no longer used by the shell at all (plus, the native module automatically handles XDG_DATA_DIRS out of the box).

I'm going to close this PR and have already deleted the obsolete Python script from the codebase entirely so it doesn't cause any more confusion. Thanks again for the contribution!

@Brainitech Brainitech closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants