fix(app-finder): changes dirs variable to query XDG_DATA_DIRS env va… - #85
Closed
seggsdungeon wants to merge 1 commit into
Closed
seggsdungeon wants to merge 1 commit into
seggsdungeon wants to merge 1 commit into
Conversation
…riable instead of fixed pat
Brainitech
requested changes
Sep 17, 2026
Brainitech
left a comment
Owner
There was a problem hiding this comment.
add /usr/share/applications as fallback incase xdg-dir is unset in the users enviroment
Owner
|
Kindly PR to the dev branch |
Owner
|
Thanks so much for taking the time to submit this fix! I actually completely forgot that I recently migrated the App Launcher to use Quickshell's native DesktopEntries module over on the dev branch. Because of that architectural change, list_apps.py is now dead code and no longer used by the shell at all (plus, the native module automatically handles XDG_DATA_DIRS out of the box). I'm going to close this PR and have already deleted the obsolete Python script from the codebase entirely so it doesn't cause any more confusion. Thanks again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(app-finder): changes dirs variable to query XDG_DATA_DIRS env variable instead of fixed path
Overview
Type of Change
Testing Checklist
Related Issues