Added GPU support for both CUDA and Metal, re-enabled 2D support, and updated tests - #9
Open
JaredW40 wants to merge 7 commits into
Open
Added GPU support for both CUDA and Metal, re-enabled 2D support, and updated tests#9JaredW40 wants to merge 7 commits into
JaredW40 wants to merge 7 commits into
Conversation
…tests as well. In addition, full 2D support (MonogenicFilterFlux.jl) has been re-enabled for both GPU and CPU. Future work in this package would be plotting functionality for the third layer in 1D, as well as 2D plotting functions (and docs examples).
…kages from the JaredW40 repository versions. Will be updated when those are pushed to UCD4IDS repositories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like ContinuousWavelets.jl, FourierFilterFlux.jl and MonogenicFilterFlux.jl, support has been added for both CUDA and Metal GPU's. To load the GPU methods, prior to importing ScatteringTransform,jl import the files listed in the Project.toml for either CUDA or Metal. Similarly, the plots are in an extension file and are only natively usable if Plots.jl is imported prior to this package.
With the updates to MonogenicFilterFlux.jl, 2D scattering transforms are now fully GPU capable and error free. In line with this fix, testing has been updated to test 2D again, as well as being more extensive in checking the various functions of ScatteringTransform.jl.
Much like the other packages, the changes made in this pull request are great enough to warrant a version update. The previous version of ScatteringTransform.jl was 0.9.0, so it would make the most sense to update to 0.10.0.