Repository navigation
fix(mobile): draw generated Bot avatars into Android notification PNGs - #2483
Merged
Merged
Conversation
Generated Bot avatars are SVG, which expo-image cannot load into a bitmap on Android, so bot-<slug>.png was never written and Bot notifications showed a blank avatar. The conversation-notifications module now rasterizes the SVG with androidsvg. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JrtPca5pD72Gdx4CFkQdNi
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JrtPca5pD72Gdx4CFkQdNi
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 6
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DoodleBears
added a commit
that referenced
this pull request
Oct 21, 2026
…ground, avatars) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why
A phone check of #2465 on Android found that every Bot notification has a blank avatar slot showing only the small app badge. That covers both DMs and approvals. The Channel image displays correctly. The tester narrowed it down: once a Bot is given a PNG avatar with
bot-avatar-set, its notification avatar works. Bots on the default generated avatar don't.Generated avatars reach
native-notification-avatars.tsasdata:image/svg+xml. On Android, theImage.loadAsync+ImageManipulatorpath cannot decode SVG into a bitmap, sobot-<slug>.pngis never written.ConversationStylethen has no Person/shortcut icon.Change outline
notification-avatars.ts: a generated avatar'sAvatarImagealso carries the rawsvg.conversation-notificationsmodule addsrasterizeSvgAsync(svg, target, size). It draws the SVG into a 192×192 PNG with androidsvg (the sameandroidsvg-aar:1.4expo-image already depends on), writing to a temp file and then renaming it.native-notification-avatars.ts: on Android, SVG avatars go through that function, and everything else keeps the expo-image path. iOS is unchanged.Verification
tscpasses, andnotification-avatars.test.tspasses (7 tests, including the newsvgfield).Generated by Claude Code