Skip to content

fix(mobile): keep folder path chips from collapsing on Android - #2427

Merged
DoodleBears merged 2 commits into
mainfrom
claude/project-thread-gi4bet
Oct 21, 2026
Merged

DoodleBears merged 2 commits into
mainfrom
claude/project-thread-gi4bet

Conversation

@DoodleBears

Copy link
Copy Markdown
Contributor

Requested by Vain · project thread

Why the change

On a real Android phone, the breadcrumb chips at the top of the 允许文件夹读写 sheet rendered as empty pills with only a few dots of text. React Native's horizontal ScrollView defaults to flexGrow: 1, flexShrink: 1. The sheet is a height-bound column, so a long folder list (here C:\Users\admin) squeezed the crumb row below the chip height and clipped the text.

Issue / Discussion: Refs #2392, #2421.

Special things to note

  • Merge risk: one style line on Crumbs in apps/mobile/src/ui/chat/workspace-sheet.tsx (flexGrow: 0, flexShrink: 0), the same pattern markdown-table.tsx / markdown-text.tsx already use for horizontal scrollers. The fix applies to both folder sheets, since they share Crumbs. Reverting is trivial.
  • The reported 将授权:C:\Users\admin line is correct: the sheet was browsing the Host home, and the registered qa-2421-grant row is a separate shortcut. With the crumbs readable, the row will show C:\ › Users › admin, matching that line.
  • Verification: mobile typecheck, grant-request-card and style-guard tests pass. The Expo Web export does not reproduce the collapse: I extended the web journey with 24 extra folders and the crumb row kept its height without the fix, so web cannot prove the fix. The mobile unit tests render through a DOM shim without RN styles, so no style assertion was added. A native Android recheck with light and dark screenshots is queued.
  • CI test plan: affected.

Change outline

 <ScrollView
   horizontal
   showsHorizontalScrollIndicator={false}
   accessibilityRole="toolbar"
+  style={{ flexGrow: 0, flexShrink: 0 }}

Before (real Android, reported): the crumb pills are clipped to dots above 已在电脑上登记的文件夹. After: native screenshots will be added by the Android recheck.


Generated by Claude Code

React Native's horizontal ScrollView defaults to flexShrink 1. In the
folder sheet, a long folder list squeezed the breadcrumb row until the chip
text was clipped to a few dots on a real Android phone. The row now keeps
its natural height, as the Markdown table scroller already does.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GzQmtMAahcsx9doCNJgFLe
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GzQmtMAahcsx9doCNJgFLe
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fb8bd86e-4d90-4cc9-a64c-f1a3522ae83d
📥 Commits

Reviewing files that changed from the base of the PR and between 9d0c4fb and 96fa6aa.

📒 Files selected for processing: 2
  • apps/mobile/src/ui/chat/workspace-sheet.tsx
  • changes/2427-phone-folder-crumbs.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DoodleBears DoodleBears self-assigned this Oct 20, 2026
DoodleBears added a commit that referenced this pull request Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Copy link
Copy Markdown
Contributor Author

Android phone result: PASS (Xiaomi, Android 16 / HyperOS 3, this branch at 96fa6aa, isolated QA Host)

Screenshots: 2427-android-folders/phone (commit b62cc9d): 1-home-crumbs-{light,dark}.png (C:\ > Users > , user segment redacted), 2-bhqa-crumbs-{light,dark}.png (D:\ > bhqa). The path chips are full height with readable text. No folder was granted.


Generated by Claude Code

@DoodleBears
DoodleBears merged commit c31c2d4 into main Oct 21, 2026
11 checks passed
@DoodleBears
DoodleBears deleted the claude/project-thread-gi4bet branch October 21, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants