Repository navigation
fix(mobile): keep folder path chips from collapsing on Android - #2427
Conversation
React Native's horizontal ScrollView defaults to flexShrink 1. In the folder sheet, a long folder list squeezed the breadcrumb row until the chip text was clipped to a few dots on a real Android phone. The row now keeps its natural height, as the Markdown table scroller already does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GzQmtMAahcsx9doCNJgFLe
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GzQmtMAahcsx9doCNJgFLe
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Android phone result: PASS (Xiaomi, Android 16 / HyperOS 3, this branch at 96fa6aa, isolated QA Host) Screenshots: 2427-android-folders/phone (commit b62cc9d): Generated by Claude Code |
Requested by Vain · project thread
Why the change
On a real Android phone, the breadcrumb chips at the top of the 允许文件夹读写 sheet rendered as empty pills with only a few dots of text. React Native's horizontal
ScrollViewdefaults toflexGrow: 1, flexShrink: 1. The sheet is a height-bound column, so a long folder list (hereC:\Users\admin) squeezed the crumb row below the chip height and clipped the text.Issue / Discussion: Refs #2392, #2421.
Special things to note
Crumbsinapps/mobile/src/ui/chat/workspace-sheet.tsx(flexGrow: 0, flexShrink: 0), the same patternmarkdown-table.tsx/markdown-text.tsxalready use for horizontal scrollers. The fix applies to both folder sheets, since they shareCrumbs. Reverting is trivial.将授权:C:\Users\adminline is correct: the sheet was browsing the Host home, and the registeredqa-2421-grantrow is a separate shortcut. With the crumbs readable, the row will showC:\ › Users › admin, matching that line.grant-request-cardandstyle-guardtests pass. The Expo Web export does not reproduce the collapse: I extended the web journey with 24 extra folders and the crumb row kept its height without the fix, so web cannot prove the fix. The mobile unit tests render through a DOM shim without RN styles, so no style assertion was added. A native Android recheck with light and dark screenshots is queued.Change outline
<ScrollView horizontal showsHorizontalScrollIndicator={false} accessibilityRole="toolbar" + style={{ flexGrow: 0, flexShrink: 0 }}Before (real Android, reported): the crumb pills are clipped to dots above 已在电脑上登记的文件夹. After: native screenshots will be added by the Android recheck.
Generated by Claude Code