Skip to content

chore: delete the canton-barebones folder - #120

Open
gabitoesmiapodo wants to merge 2 commits into
feat/116from
feat/119
Open

chore: delete the canton-barebones folder#120
gabitoesmiapodo wants to merge 2 commits into
feat/116from
feat/119

Conversation

@gabitoesmiapodo

@gabitoesmiapodo gabitoesmiapodo commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Closes #119

The folder was a husk after PR #118 moved its scripts to root scripts/ and rewired the loop to the external LocalNet tool. Twenty-two doc references still described it as a live subproject.

Changes

  • canton-barebones/ is gone, prebuilt DAR and dead splice config included
  • .dockerignore is gone; nothing in the repo builds an image
  • Workspace, Biome and lint-staged configs no longer name canton-barebones
  • Docs frame the LocalNet and wallet-service as dependencies, not subprojects
  • dapp/daml/PROVENANCE.md records that pnpm build-dar produces the DAR

Review guide

Nothing here needs close reading. The judgement calls are two: the PROVENANCE.md wording, which moved the build-produced DAR out of the Imported row, and the rows dropped from root CLAUDE.md's two tables.

Worth one check: that nothing outside the deleted folder still points at it, and that .gitleaksignore was left untouched — its entries are commit fingerprints the pre-push hook still needs.

Deviations

  • References naming the external @bootnodedev/canton-barebones tool and its init/start/reset commands stay in README.md, CLAUDE.md and architecture.md: those are the LocalNet setup instructions, so the criterion is met as no reference to the deleted folder
  • PROVENANCE.md records the build-produced DAR in the paragraph above the table rather than inside the "Imported" row, which now lists only what was vendored

Acceptance criteria

  • canton-barebones/ deleted in full, prebuilt DAR included
  • .dockerignore deleted; no Dockerfile remains anywhere in the repo
  • dapp/daml/PROVENANCE.md "Imported" row records that pnpm build-dar produces the DAR
  • pnpm-workspace.yaml, biome.json and .lintstagedrc.format.mjs no longer name canton-barebones
  • .gitleaksignore untouched
  • No canton-barebones reference left in CLAUDE.md, README.md, architecture.md, canton-connect/CLAUDE.md, canton-connect/architecture.md, canton-dappbooster/CLAUDE.md
  • Root CLAUDE.md Subprojects and Documentation Distribution tables drop the canton-barebones row
  • Local loop verified: LocalNet up, DAR deployed, wallet-service on 3010, bootstrap run, grant visible in the dApp on 3012
  • pnpm lint, typecheck, test, build, knip, docs:check and check:anatomy all pass

Test plan

Automated tests

  1. Run pnpm install
  2. From the root, run pnpm lint, pnpm typecheck, pnpm test, pnpm build, pnpm knip, pnpm docs:check and pnpm run check:anatomy
  3. Expect all seven to pass

Manual verification

  1. Check out this branch and run pnpm install
  2. Confirm no canton-barebones/ directory and no .dockerignore in the tree
  3. Scaffold the LocalNet elsewhere with npx @bootnodedev/canton-barebones init, then set validators.appUser.ui and sv.scanUI to true
  4. Run ./scripts/dev-stack.sh up <dir>, then pnpm build-dar, pnpm deploy-dar -- <dar> and pnpm run bootstrap
  5. Run pnpm app:dev and connect a CIP-0103 wallet at http://localhost:3012
  6. Expect the connect request to reach the wallet and the vesting grant to load

Breaking changes

None.

Checklist

  • Self-reviewed my own diff
  • Tests added or updated
  • Docs updated (if applicable)
  • No unrelated changes bundled in

Screenshots

None.

The folder was a husk: a package.json keeping it a workspace member, a README
for a stack that moved out, a superseded .env.example, two unreferenced splice
config files, and a prebuilt DAR. The LocalNet is the external
@bootnodedev/canton-barebones now, and it ships its own overrides.

.dockerignore existed for the wallet-service image build; no Dockerfile remains
anywhere in the repo.

pnpm build-dar reproduces the DAR and dev-stack.sh builds it before deploying,
so PROVENANCE.md no longer lists it as a vendored artifact.

.gitleaksignore keeps its canton-barebones lines: they are commit fingerprints
for history gitleaks still scans on the outgoing range.
The Subprojects and Documentation Distribution tables each carried a
canton-barebones row, and architecture.md still called it the local participant
wrapper. Both the LocalNet and wallet-service are dependencies reached from
outside the repository now, so the Subprojects trailer says so for the two of
them together.

The app-agnostic rules drop the folder from the list of trees a library may not
import from.
@gabitoesmiapodo gabitoesmiapodo self-assigned this Aug 28, 2026
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
demo.canton-dappbooster Ready Ready Preview Aug 28, 2026 12:13am
docs.canton-dappbooster Ready Ready Preview Aug 28, 2026 12:13am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Delete the canton-barebones folder

1 participant