Remove duplicate windowing useEffect left by merge conflict#36
Merged
Conversation
A bad merge-conflict resolution left a third useEffect that set centerInput to the un-negated window center, overwriting the scoped effect above it and reintroducing the Brightness textbox/slider mismatch. The two scoped effects already keep both inputs in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #35. The merge that brought #35 into
main(alongside the online-3D branch) left a duplicate, conflictinguseEffectinWindowingSlider.tsx:It ran after the two scoped effects on every window change and overwrote
centerInputwith the un-negated center, reintroducing the Brightness textbox/slider mismatch that #35 fixed.Fix
Removed the stray effect. The two existing scoped effects already keep
widthInputandcenterInput(negated, matching the slider) in sync when the parent changes the CT window.