Saved cases (bookmarks) + jump-to-organ 3D crosshair fix#33
Merged
Conversation
- savedCases helper: bookmarked case ids persisted in localStorage, storing each card's metadata at save time so the Saved view renders with no extra fetch (mirrors the recentUploads pattern). Unit-tested. - Bookmark toggle on each dataset card (gold when saved); stops propagation so it doesn't open the case. - "Saved (N)" toggle on the dashboard swaps the grid to show only bookmarked cases, with an empty state; syncs across cards and tabs.
Jump-to-organ moved the 2D MPR crosshair but not the NiiVue 3D view, because the Cornerstone crosshair move suppresses its change event (to avoid sync loops). Move the NiiVue crosshair explicitly in the jump handler so all four views recenter, and drop the now-unused jumpToOrgan helper in favor of getOrganCentroids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes, frontend-only.
1. Saved cases (bookmarks)
Bookmark dataset cases and view them in one place.
savedCaseshelper — bookmarked case ids in localStorage, storing each card's metadata at save time so the Saved view renders with no extra backend/metadata fetch (mirrors therecentUploadspattern). 5 unit tests.2. Jump-to-organ 3D crosshair fix
The jump-to-organ feature (merged in #32) moved the 2D MPR crosshair but left the 3D (NiiVue) view where it was — the Cornerstone crosshair move suppresses its change event (to avoid sync loops), so the 3D view never got updated. The jump handler now moves the NiiVue crosshair explicitly, so all four views recenter. Replaces the now-unused
jumpToOrganhelper withgetOrganCentroids.Testing
tsc -b) ✓