You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To reduce the scope of #405 and have a discussion on some of the points, I have decided to created an issue describing the leftovers
Add a padding helper for Bitcoin.
#405 only pads with an annex (Cost::get_padding, Cost::get_annex_padding_size).
The draft TapSimplicity rules (BIN-2026-0003) instead pad with one all-zero item at the bottom of the witness stack, which must be minimal.
One byte longer is invalid, and an empty item is valid.
The helper should take the whole witness, say where the item goes, and be selected by name rather than by Cargo features (12).
U32Weight, its conversions, and now Cost::is_budget_valid and Cost::get_annex_padding_size are all gated on bitcoin only.
The generated simplicity_sys::c_jets::jets_wrapper functions are safe pub fns that dereference raw pointers, so they can be crashed without unsafe (e.g. a CFrameItem with a null edge).
They should be unsafe fn, or not public.
Release simplicity-sys before the next simplicity-lang, and bump the dependency. simplicity-lang uses the Bitcoin jets_wrapper functions (already on master) and, in its tests, simplicity_sys::tests::BITCOIN_PRIMITIVE_JET_NODE_INC.
Would like to get comments on all of those if possible
// The environment hashes of `Fixture::new()`.constTX_HASH:&str = "1032104862fdcc0a976cad6da0fbb47ddd67930a1f83cc7d69a4d5cf6addea69";constTAP_ENV_HASH:&str = "c744c712ef26db826c3904d7471bf4d5d1a53fdf7c663a9a5e4d681026f6c06f";constSIG_ALL_HASH:&str = "c65d5cff65c29c1417783930350af2045e0ec92d6dfa7f0ff02a4826453c7c8b";
These were computed outside this crate and outside the C library, by hashing the preimages the C code hashes (bitcoin/env.c, bitcoin/txEnv.c and bitcoin/ops.c) with Python's hashlib.
Activity
KyrylR commentedon Nov 19, 2026
In regard to the (commit TBD):
These were computed outside this crate and outside the C library, by hashing the preimages the C code hashes (
bitcoin/env.c,bitcoin/txEnv.candbitcoin/ops.c) with Python'shashlib.Not sure whether we should include it into the code comments