Repository navigation
0.11 dogfood fixes: live verify names the verifier; the man page stays under the install prefix - #60
Merged
Merged
Conversation
…tall.sh keeps the man page under <prefix>/bin's prefix
…erated on Linux with this branch's build)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two fixes from the 0.11 dogfood run. Version stays 0.12.0 here; the bump to 0.12.1 is the release's job. Draft: not for merge until reviewed.
F1:
live verifynames the verifierprobbit live verifyprinted the strand header'senginealone, so after an upgrade a strand written by the old engine read as if the old engine were still installed.engine(the header's, the engine that wrote the strand) and addsverified_by(the engine that replayed it). Every other key and the exit codes are unchanged.docs/persona.md§5.7,docs/agents.md(probbit_live_verifyrow), the MCP tool description,python/probbit.pylive_verifydocstring.python/probbit_host.py receipts: when the verify answer hasverified_by, the header line printswritten by <engine>, verified by <verified_by>.bench/agentdojo/receipts-example.txtand the block indocs/receipts.mdwere regenerated with this branch's build; only the header line changed. The release should regenerate it after the bump, so it shows the released version.verify_names_the_writer_and_the_verifier: one strand written by the released 0.11.0 (a member ofbench/agentdojo/tables/strands-A.tar.gz, committed asprobbit-cli/tests/fixtures/strands/agentdojo-0.11.0.strand, 2,393 bytes) verifies withengine: "probbit 0.11.0"andverified_by: "probbit 0.12.0"(this engine). The existing 0.9.0-dev fixture test also assertsverified_by.F2: the man page stays under the install prefix
install.shwrote the man page to~/.local/share/man/man1/even whenPROBBIT_INSTALL_DIRpointed somewhere else.PROBBIT_INSTALL_DIR=<prefix>/binwith noPROBBIT_MAN_DIRnow installs it to<prefix>/share/man/man1/.PROBBIT_INSTALL_DIRkeeps the HOME default, and the installer's line now says the page went outside the install dir (PROBBIT_MAN_DIRto choose).PROBBIT_MAN_DIRstill wins, and a failure is still not fatal.scripts/bench/test_install_sh.shgains cases 6a (prefix/bin: the page is in the prefix, nothing under HOME) and 6a' (a dir that is not a bin dir: the page goes under HOME and the installer says so).docs/CHEATSHEET.md, andprobbit man's own text (help table, plus the committeddocs/probbit.1) say where the page lands.install.ps1installs no man page, so it is unchanged.Tested where
All gates ran on a Linux x86_64 build node (Ubuntu 24.04, cargo 1.99.1). It ran one gate at a time and removed the target dir afterwards:
macOS: python unittest only (60 OK), against the installed 0.12.0 binary.
Not tested here
cargo fmtandclippy: CI runs neither, and main is not rustfmt-formatted (cargo fmt --checkon main reports 122,663 diff lines).