feat: add gasevm (Neo X) EVM chain support#368
Open
imkushagra12-bitgo wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Neo X (gasevm) EVM chain support across deployment tooling so the V4 wallet + Batcher contracts can be deployed/verified and CI workflows can recognize gasevm/tgasevm release tags.
Changes:
- Added
GASEVM/GASEVM_TESTNETchain IDs and wired them into chain-specific gas configuration. - Added Hardhat network + explorer verification configuration entries for gasevm/tgasevm.
- Updated deploy workflows to recognize
gasevm/tgasevmtags and allow deploy jobs to run for those networks.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/chainConfig.ts | Adds Neo X chain cases with explicit EIP-1559 gas params. |
| hardhat.config.ts | Adds gasevm networks + explorer customChains and adjusts Sourcify config. |
| deployUtils.ts | Adds Neo X verification overrides (confirmation blocks / retry behavior). |
| config/chainIds.ts | Introduces GASEVM and GASEVM_TESTNET chain IDs. |
| config/batcherDeployGasConfig.ts | Adds Neo X “manual-gas” strategy with minimum priority fee. |
| .github/workflows/deploy_batcher_contract.yml | Extends tag parsing + deploy gating to include gasevm/tgasevm. |
| .github/workflows/deploy_and_release.yml | Extends tag parsing + deploy gating to include gasevm/tgasevm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1078
to
+1080
| sourcify: { | ||
| enabled: true | ||
| }, |
Comment on lines
+21
to
+24
| [CHAIN_IDS.HOODETH]: { confirmationBlocks: 2, maxRetries: 2 }, | ||
| // Neo X: Blockscout explorer does not support Etherscan-compatible verification API | ||
| [CHAIN_IDS.GASEVM]: { confirmationBlocks: 5, maxRetries: 0 }, | ||
| [CHAIN_IDS.GASEVM_TESTNET]: { confirmationBlocks: 5, maxRetries: 0 } |
imkushagra12-bitgo
force-pushed
the
feat/gasevm-contract-deployment
branch
from
4631df4 to
000d07f
Compare
| > = { | ||
| [CHAIN_IDS.HOODETH]: { confirmationBlocks: 2, maxRetries: 2 } | ||
| [CHAIN_IDS.HOODETH]: { confirmationBlocks: 2, maxRetries: 2 }, | ||
| // Neo X: Blockscout explorer does not support Etherscan-compatible verification API |
Comment on lines
2156
to
2158
| sourcify: { | ||
| enabled: false | ||
| enabled: true | ||
| }, |
imkushagra12-bitgo
force-pushed
the
feat/gasevm-contract-deployment
branch
from
55f8128 to
4cbb11a
Compare
Comment on lines
+2139
to
+2144
| network: 'gasevmTestnet', | ||
| chainId: CHAIN_IDS.GASEVM_TESTNET, | ||
| urls: { | ||
| apiURL: 'https://xt4scan.ngd.network:8877/api', | ||
| browserURL: 'https://neoxt4scan.ngd.network' | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The different subdomain is intentional — xt4scan.ngd.network:8877 is the verified API endpoint for the Neo X testnet Blockscout instance.
Comment on lines
+495
to
+500
| // maxRetries: 0 means verification is intentionally disabled for this chain | ||
| if (maxRetries === 0) { | ||
| logger.warn( | ||
| `Auto-verification disabled for ${contractName} on this chain. Please verify manually.` | ||
| ); | ||
| return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Neo X (
gasevm) EVM chain support to eth-multisig-v4 and deploys V4 wallet + Batcher contracts on testnet.Changes
config/chainIds.ts— AddedGASEVM(47763) andGASEVM_TESTNET(12227332)scripts/chainConfig.ts— Gas config for gasevm (EIP-1559, maxFeePerGas: 50 Gwei, maxPriorityFeePerGas: 20 Gwei, gasLimit: 3_000_000). Neo X requires minGasTipCap of 20 Gwei.hardhat.config.ts— Network entries, apiKey, and customChains for explorer verificationconfig/batcherDeployGasConfig.ts— manual-gas strategy with minPriorityFeeGwei: 20 for Neo XdeployUtils.ts— CHAIN_VERIFICATION_OVERRIDES: maxRetries: 0 (manual verification via Blockscout API).github/workflows/deploy_and_release.yml— Added gasevm/tgasevm to tag regex and deploy conditions.github/workflows/deploy_batcher_contract.yml— Added gasevm/tgasevm to tag regex and deploy conditionsDeployed Addresses (Testnet: tgasevm, chainId: 12227332)
0x6fd2b4c6dd1150fce228d02785cbf69f811b7e760x654C828882eBb78F191129CD04C90635bB85258C0xca07f6C84a787b38299c61c865ca526fF88f69bA0xcA5944d45B5EA52a8bC50D011DcF6398327d66e90x93a2299BcC9A55a886D74eE3447C787f38c3d988Explorer
Testnet: https://neoxt4scan.ngd.network
Notes
Ticket: CECHO-1465