Skip to content

feat: wrapApprove intent wiring (sendMany type + prebuild + shieldParams passthrough) - #9556

Draft
0xPrabh wants to merge 1 commit into
masterfrom
CHALO-1340
Draft

feat: wrapApprove intent wiring (sendMany type + prebuild + shieldParams passthrough)#9556
0xPrabh wants to merge 1 commit into
masterfrom
CHALO-1340

Conversation

@0xPrabh

@0xPrabh 0xPrabh commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Description

Wires sendMany({ type: 'wrapApprove' | 'wrap', shieldParams }) so a wrap intent can reach wallet-platform.

Wallet.send() remains a single-payment helper (address + amount). Wrap has no client recipient; WP builds the calldata from tokenName and amount. This change:

  • Adds wrapApprove / wrap as TSS prebuildTransaction intent types
  • Passes shieldParams: { tokenName, amount } through BuildParams / populateIntent
  • Flattens those fields onto the WP intent (tokenName, amount)
  • Allows no-recipient wrap in NO_RECIPIENT_TX_TYPES (wrapApprove was already listed)

Issue Number

CHALO-1340

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

npx mocha test/unit/bitgo/utils/mpcUtils.wrapApprove.ts
npx mocha test/unit/bitgo/utils/tss/recipientUtils.ts test/unit/bitgo/wallet/BuildParams.ts

(from modules/sdk-core)

Also added bitgo wallet unit tests for prebuildTransaction / populateIntent. Those require a full monorepo install (missing @bitgo/sdk-coin-pearl in this local tree).

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My commits follow Conventional Commits
  • The ticket was included in the commit message as a reference
  • I have added tests that prove my fix is effective or that my feature works

Made with Cursor

Ticket: CHALO-1340
Co-authored-by: Cursor <cursoragent@cursor.com>
@0xPrabh
0xPrabh requested review from a team as code owners August 25, 2026 07:06
@linear-code

linear-code Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

CHALO-1340

@0xPrabh 0xPrabh changed the title CHALO-1340: [SDK] wrapApprove intent wiring (sendMany type + prebuild + shieldParams passthrough) feat: wrapApprove intent wiring (sendMany type + prebuild + shieldParams passthrough) Aug 25, 2026
@0xPrabh
0xPrabh marked this pull request as draft August 25, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant