fix(sdk-coin-eth): fix verifyTransaction for zama TSS tx#9188
Merged
Conversation
TICKET: CHALO-726
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: CHALO-726
This pull request updates the logic for detecting ERC-7984 token consolidation transactions to support a new TSS MPCv2 signing path and adds corresponding unit tests to ensure correct behavior. The main focus is to recognize transactions with the type
consolidateTokenas valid consolidations, addressing a previously broken verification path.ERC-7984 Token Consolidation Improvements:
isConsolidationTransactionlogic inerc7984Token.tsto recognize transactions wheretxParams.typeis'consolidateToken', ensuring support for the TSS MPCv2 signing path.Unit Test Enhancements:
erc7984Token.tsto verify that transactions withtype: 'consolidateToken'are correctly identified as consolidations and properly validated, including both acceptance and rejection scenarios based on address matching.