fix(sdk-core): migrate MPCv2 EdDSA address derivation to BIP32-Ed25519#9179
Merged
Conversation
Replace Silence Labs single-HMAC formula (deriveUnhardenedMps) with the standard BIP32-Ed25519 dual-HMAC formula (Eddsa.deriveUnhardened) for MPCv2 EdDSA address derivation in addressVerification.ts. Both MPCv1 and MPCv2 ed25519 wallets now use the same derivation path through EDDSAMethods.getInitializedMpcInstance(). Ticket: WCI-644 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Silence Labs single-HMAC formula (deriveUnhardenedMps) with the standard BIP32-Ed25519 dual-HMAC formula (Eddsa.deriveUnhardened) for MPCv2 EdDSA address derivation in addressVerification.ts.
Both MPCv1 and MPCv2 ed25519 wallets now use the same derivation path through EDDSAMethods.getInitializedMpcInstance().
Ticket: WCI-644