Repository navigation
u2fhid: reject oversized outgoing payloads - #192
Merged
benma merged 1 commit intoOct 13, 2026
Merged
Conversation
U2F HID permits one initialization packet and at most 128 continuation packets, limiting payloads to 7609 bytes with 64-byte reports. sendFrame previously emitted continuation sequence numbers above 127, and payloads larger than 65535 bytes also had their advertised length truncated. Reject payloads above the protocol limit before allocating packet buffers or writing to the device. Derive the limit from the report payload sizes.
benma
marked this pull request as ready for review
October 13, 2026 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
U2F HID permits one initialization packet and at most 128 continuation
packets, limiting payloads to 7609 bytes with 64-byte reports. sendFrame
previously emitted continuation sequence numbers above 127, and payloads
larger than 65535 bytes also had their advertised length truncated.
Reject payloads above the protocol limit before allocating packet buffers
or writing to the device. Derive the limit from the report payload sizes.