fix(exit): stop misclassifying clean macOS exits and losing provider backups - #73
Open
zhushihao wants to merge 1 commit into
Open
fix(exit): stop misclassifying clean macOS exits and losing provider backups#73zhushihao wants to merge 1 commit into
zhushihao wants to merge 1 commit into
Conversation
…ckups - Add macOS process identity via proc_pidpath + proc_pidinfo instead of /proc - Classify a clean exit without crash as CleanExit so it no longer triggers recovery warnings - Keep a clean live backup for apps whose takeover remains enabled on exit - Rebuild a missing or placeholder backup from the current provider before restart takeover - Restore the full user backup on crash restart instead of falling back to provider-only SSOT
Contributor
Author
|
Note: the backend failures are pre-existing Clippy issues under stable Rust 1.95. They occur on upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proc_pidpathandproc_pidinfoinstead of assuming Linux/procis available.CleanExit.Root cause
The exit monitor treated a missing Linux-style
/procself entry as an unclean exit on macOS. This made normal exits look like crashes. Recovery then used a narrower provider SSOT snapshot and could drop fields that only existed in the full user backup.Validation
cargo check -p cc-switch --libapp_exit_monitor::testsprocess_identity::testsservices::proxy::tests, including regression coverage for clean exits, planned restarts, confirmed panics, backup preservation/rebuild, and full backup restoration.