Prevent Boxed from resetting player progress on non-Boxed island resets#125
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
tastybento
May 29, 2026 23:08
View session
The floating jitpack snapshot v1.21-SNAPSHOT resolves to an ephemeral git-described build whose jar/POM get evicted, breaking CI even on unchanged commits. Switch to the equivalent stable Maven Central coordinates (org.mockbukkit.mockbukkit:mockbukkit-v1.21:4.110.0). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Boxed was clearing player advancements/statistics on
IslandNewIslandEventeven when the reset originated from a non-Boxed island. This leaked Boxed reset behavior across game modes.Event scoping fix
AdvancementListener#onFirstTimeto no-op unless the event island belongs to a Boxed world.Regression coverage
IslandNewIslandEventfor a non-Boxed island and asserts the reset flow is not entered (no player UUID access / no clear path trigger).