Skip to content

Parse PAPI placeholders for reward commands#269

Merged
BenCodez merged 1 commit into
BenCodez:masterfrom
RapidGravy:fix/reward-command-papi-placeholders
Jun 6, 2026
Merged

Parse PAPI placeholders for reward commands#269
BenCodez merged 1 commit into
BenCodez:masterfrom
RapidGravy:fix/reward-command-papi-placeholders

Conversation

@RapidGravy
Copy link
Copy Markdown
Contributor

This fixes an issue where PAPI placeholders in reward console commands were not being parsed against the player receiving the reward.

The issue showed up with VotingPlugin reward broadcasts that run through ChatControl. A reward command using something like %essentials_nickname% could get sent through before that placeholder was resolved, which meant ChatControl would parse it later for each person viewing the message. So instead of everyone seeing the rewarded player’s nickname, each player would see their own nickname in the broadcast.

This change makes reward console commands resolve placeholders against the reward target before the command is sent. JavaScript parsing still happens after that if it is enabled, but PAPI parsing no longer depends on that path.

Tested with VotingPlugin reward commands that run ChatControl broadcasts using %essentials_nickname%, and the broadcast now correctly shows the rewarded player’s nickname to all viewers. This started happening after the reward command placeholder flow changed so PAPI parsing was no longer reached unless the JavaScript parsing path also ran.

@BenCodez BenCodez merged commit 7e1d05f into BenCodez:master Jun 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants