Parse PAPI placeholders for reward commands#269
Merged
BenCodez merged 1 commit intoJun 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where PAPI placeholders in reward console commands were not being parsed against the player receiving the reward.
The issue showed up with VotingPlugin reward broadcasts that run through ChatControl. A reward command using something like
%essentials_nickname%could get sent through before that placeholder was resolved, which meant ChatControl would parse it later for each person viewing the message. So instead of everyone seeing the rewarded player’s nickname, each player would see their own nickname in the broadcast.This change makes reward console commands resolve placeholders against the reward target before the command is sent. JavaScript parsing still happens after that if it is enabled, but PAPI parsing no longer depends on that path.
Tested with VotingPlugin reward commands that run ChatControl broadcasts using
%essentials_nickname%, and the broadcast now correctly shows the rewarded player’s nickname to all viewers. This started happening after the reward command placeholder flow changed so PAPI parsing was no longer reached unless the JavaScript parsing path also ran.