Skip to content

fix(trigger-coolify-deploy): retry PR-preview trigger on 2xx not-found body #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andreas-Garcia merged 2 commits into from
Sep 15, 2026
Merged

fix(trigger-coolify-deploy): retry PR-preview trigger on 2xx not-found body #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2796a5a
fix(trigger-coolify-deploy): retry PR-preview trigger on 2xx not-foun…
Andreas-Garcia Sep 15, 2026
d031b43
docs(changelog): note 2xx not-found retry fix under Unreleased
Andreas-Garcia Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/trigger-coolify-deploy/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ runs:
raw=$(trigger_deploy)
http_code=$(printf '%s' "$raw" | tail -1)
response=$(printf '%s' "$raw" | sed '$d')
if [ "$http_code" -ge 200 ] && [ "$http_code" -lt 300 ]; then
if [ "$http_code" -ge 200 ] && [ "$http_code" -lt 300 ] && printf '%s' "$response" | jq -e '.deployments[0].deployment_uuid' >/dev/null 2>&1; then
break
fi
if printf '%s' "$response" | grep -qi "not found"; then
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ All contributors (including maintainers) should update `CHANGELOG.md` when creat

## [Unreleased]

### Fixed

- **trigger-coolify-deploy**: the PR-preview deploy trigger's retry loop now also retries when Coolify returns HTTP 200 with a "not found" error embedded in the JSON body (no `deployment_uuid`) instead of a non-2xx status. Previously this broke out of the retry loop on the first attempt and hard-failed instead of retrying for up to `PREVIEW_NOT_FOUND_TIMEOUT_SECONDS` while the preview resource was still being provisioned.

## [4.3.3] - 2026-09-15

### Fixed
Expand Down