Release v4.10.0 - #91
Merged
Merged
Conversation
Release v4.9.1 (merge back into develop)
GenreTreeView managed its own fetch/loading/cancellation state for the selected genre's detail via useEffect; replaced it with the existing React Query useFetchGenreDetail hook for consistent caching and error handling. Added test coverage for useFetchGenreDetail's reference/me endpoint selection and disabled-when-no-id behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rxCzstzrhcXbrqN7NpJE4
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rxCzstzrhcXbrqN7NpJE4
…-hook fix(genre-tree): use useFetchGenreDetail query hook in GenreTreeView
…tire GenreDetailPanel Bump genre-tree-view to 1.6.0 for the new renderExtraDetails render prop and thread it through TreeWheel, TreeWheelRadialPopCore, and TreePerRoot. GenreTreeView now renders essential tracks and archived track count inside the library's own info panel via this prop, with a staleness guard against info-panel chip navigation bypassing onNodeClick. The standalone GenreDetailPanel component and its export are removed as redundant. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rxCzstzrhcXbrqN7NpJE4
…ential-tracks-panel feat(genre-tree): surface essential tracks via renderExtraDetails, retire GenreDetailPanel
CriteriaDetailed now includes summary (nullable string), matching the backend's genre-detail/tag-detail response (grow-the-music-tree-api#67). renderExtraDetails displays it above the essential tracks list when present. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The detailed schema test fixture predated the summary field, so CriteriaDetailedSchema.parse(valid) started failing once summary became a required (nullable) key. Add it plus null/missing-key coverage mirroring the CriteriaSimpleSchema block. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ummary feat(genre-tree): surface genre summary in the info panel
The Summary field was hidden entirely when a genre had no summary set, inconsistent with the other core fields (song count, side) which always render. Show it as a labeled field with a "—" placeholder when there is no value, and only conditionally render the essential tracks and archived count sections below it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Reuse gtv-info-panel-children / gtv-info-panel-children-title classes from @behindthemusictree/genre-tree-view so Summary, Archived tracks, and Essential tracks look consistent with Song count, Side, Children, etc. instead of using ad-hoc Tailwind classes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ys-visible fix(genre-tree): always render the Summary field in the info panel
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v4.10.0 (4.9.1 -> 4.10.0). After this merges, run
pnpm tag-releaseonmainto tag and trigger the publish workflow, then merge the companion PR intodevelop.