fix(genre-tree): always render the Summary field in the info panel - #90
Merged
Merged
Conversation
The Summary field was hidden entirely when a genre had no summary set, inconsistent with the other core fields (song count, side) which always render. Show it as a labeled field with a "—" placeholder when there is no value, and only conditionally render the essential tracks and archived count sections below it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reuse gtv-info-panel-children / gtv-info-panel-children-title classes from @behindthemusictree/genre-tree-view so Summary, Archived tracks, and Essential tracks look consistent with Song count, Side, Children, etc. instead of using ad-hoc Tailwind classes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenreTreeView's info panel was hidden entirely when a genre had nosummaryset, inconsistent with the other core fields (song count, side) which always render regardless of value.Test plan
pnpm --filter @behindthemusictree/app-kit test— 542/542 passing🤖 Generated with Claude Code