feat(genre-tree): surface genre summary in the info panel - #89
Merged
Merged
Conversation
CriteriaDetailed now includes summary (nullable string), matching the backend's genre-detail/tag-detail response (grow-the-music-tree-api#67). renderExtraDetails displays it above the essential tracks list when present. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The detailed schema test fixture predated the summary field, so CriteriaDetailedSchema.parse(valid) started failing once summary became a required (nullable) key. Add it plus null/missing-key coverage mirroring the CriteriaSimpleSchema block. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CriteriaDetailednow includessummary(nullable string), matching the backend's genre-detail/tag-detail response after grow-the-music-tree-api#67, which added the field toCriteriaDetailedSerializer(it had previously only been on the simple/list serializer).GenreTreeView'srenderExtraDetailsnow renders the summary as a paragraph above the essential tracks list, when present, and includes it in the "anything to show" check that otherwise returnsnull.Test plan
pnpm --filter @behindthemusictree/app-kit test -- GenreTreeView— passes, including new coverage for summary rendering and its inclusion in the empty-state checkpnpm run lint(typecheck + build across the workspace) — passes🤖 Generated with Claude Code