Skip to content

Fix plugin loading order to match docs#133

Open
thettasch-samxl wants to merge 1 commit into
BehaviorTree:humblefrom
sam-xl:fix/plugin-loading-order
Open

Fix plugin loading order to match docs#133
thettasch-samxl wants to merge 1 commit into
BehaviorTree:humblefrom
sam-xl:fix/plugin-loading-order

Conversation

@thettasch-samxl
Copy link
Copy Markdown

Fixes #130.

The documentation states that "registerNodesIntoFactory is a callback invoked after the plugins were registered into the BT::BehaviorTreeFactory. ". This PR updates the code to match the described order.

See:

/**
* @brief registerNodesIntoFactory is a callback invoked after the
* plugins were registered into the BT::BehaviorTreeFactory.
* It can be used to register additional custom nodes manually.
*
* @param factory The factory to use to register nodes
*/
virtual void registerNodesIntoFactory(BT::BehaviorTreeFactory& factory)
{}

and the current call order, which does not match the above description:

// user defined method
registerNodesIntoFactory(p_->factory);
// load plugins from multiple directories
RegisterPlugins(p_->params, p_->factory, node_);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TreeExecutionServer plugin loading order mismatch docstring vs implementation

1 participant