Skip to content

Revert "Add Ghostscript 10.07.1 configuration and update bundle release" #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwaisner merged 1 commit into from
Jul 2, 2026
Merged

Revert "Add Ghostscript 10.07.1 configuration and update bundle release" #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions bin/ghostscript10.07.1/bearsampp.conf
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions bin/ghostscript10.07.1/update_cidfmap.bat
View file
Open in desktop

This file was deleted.

36 changes: 10 additions & 26 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,21 +914,8 @@ def getAvailableVersions() {
versions.addAll(archivedVersions)
}

// Remove duplicates and sort semantically
return versions.unique().sort { a, b ->
def aParts = a.tokenize('.').collect { it.isInteger() ? it.toInteger() : it }
def bParts = b.tokenize('.').collect { it.isInteger() ? it.toInteger() : it }
for (int i = 0; i < Math.max(aParts.size(), bParts.size()); i++) {
def aVal = i < aParts.size() ? aParts[i] : 0
def bVal = i < bParts.size() ? bParts[i] : 0
if (aVal.getClass() != bVal.getClass()) {
aVal = aVal.toString()
bVal = bVal.toString()
}
if (aVal != bVal) return aVal <=> bVal
}
return 0
}
// Remove duplicates and sort
return versions.unique().sort()
}

// Task: Build all available versions
Expand Down Expand Up @@ -1346,18 +1333,15 @@ tasks.register('checkModulesUntouched') {
println "=".multiply(70)

def sortedVersions = untouchedProps.sort { a, b ->
def aParts = a.key.tokenize('.').collect { it.isInteger() ? it.toInteger() : it }
def bParts = b.key.tokenize('.').collect { it.isInteger() ? it.toInteger() : it }
for (int i = 0; i < Math.max(aParts.size(), bParts.size()); i++) {
def aVal = i < aParts.size() ? aParts[i] : 0
def bVal = i < bParts.size() ? bParts[i] : 0
if (aVal.getClass() != bVal.getClass()) {
aVal = aVal.toString()
bVal = bVal.toString()
}
if (aVal != bVal) return aVal <=> bVal
// Simple version comparison
def aParts = a.key.tokenize('.')
def bParts = b.key.tokenize('.')
for (int i = 0; i < Math.min(aParts.size(), bParts.size()); i++) {
def aNum = aParts[i].toInteger()
def bNum = bParts[i].toInteger()
if (aNum != bNum) return aNum <=> bNum
}
return 0
return aParts.size() <=> bParts.size()
}

sortedVersions.each { version, url ->
Expand Down
2 changes: 1 addition & 1 deletion build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
bundle.name = ghostscript
bundle.release = 2026.5.31
bundle.release = 2026.4.12

@qodo-code-review qodo-code-review Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Release metadata mismatch 🐞 Bug ≡ Correctness

build.properties now sets bundle.release to 2026.4.12, but releases.properties still maps
Ghostscript 10.07.1 to a 2026.5.31-tagged artifact. Since build.gradle uses bundle.release
(bundleRelease) in output archive naming while also using releases.properties as a download source,
rebuilding 10.07.1 will produce an archive whose release tag/path doesn’t match the advertised
mapping.
Agent Prompt 
### Issue description
This revert changes the module release identifier (`bundle.release`) back to `2026.4.12`, but `releases.properties` still includes a `10.07.1` entry pointing to a `2026.5.31` GitHub release asset. The build uses `bundle.release` to name/output archives, so the repo’s advertised download mapping can diverge from what this branch would build/publish.

### Issue Context
- `build.gradle` reads `bundle.release` from `build.properties` and uses it in the output path/filename.
- `build.gradle` also uses `releases.properties` as a download source when a version is not present locally.

### Fix Focus Areas
- build.properties[1-4]
- releases.properties[1-2]
- build.gradle[26-45]
- build.gradle[248-272]
- build.gradle[720-729]

### What to change
Choose one consistent state:
1) If reverting 10.07.1 support: remove the `10.07.1` (and any `2026.5.31`) entry from `releases.properties`.
2) If keeping 10.07.1 available via `releases.properties`: revert `bundle.release` back to `2026.5.31` (and restore any other reverted release metadata as needed) so produced artifacts match the mapping.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

bundle.type = tools
bundle.format = 7z

Expand Down
Loading