Skip to content

fix: highlight overlay crash and duplicated text on multi-line inserts #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BearToCode merged 2 commits into from
Sep 19, 2026
Merged

fix: highlight overlay crash and duplicated text on multi-line inserts #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
541156d
fix: don't advance the speculative diff position past the last line
TimeOfPassage Sep 19, 2026
eba72f9
fix: keep the speculative diff baseline in sync when an update throws
TimeOfPassage Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/carta-md/src/lib/internal/components/Input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@
return { html, timestamp };
} catch (e) {
console.error(`Error executing speculative update: ${e}.`);
// The overlay still holds the previous text, but the debounced highlight is already
// on its way and will render `value`. Keep the baseline in sync with it, otherwise it
// stays at the pre-change text and the next patch sees the whole document as added,
// replaying it into the overlay (the text is duplicated until the debounce lands).
currentlyHighlightedValue = value;
}
}

Expand Down
7 changes: 6 additions & 1 deletion packages/carta-md/src/lib/internal/speculative.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,12 @@ function checkPosition(position: Position, lines: Element[]): Position {
if (nextPosition.span >= lineElement.children.length) {
nextPosition.char = 0;
nextPosition.span = 0;
nextPosition.line = line + 1;
// Only advance to the next line if there is one. The overlay of an empty document is a
// single line without spans (`<span class="line"></span>`), so wrapping past it would
// leave `line` at `lines.length`; writing there reads `children` of `undefined`.
if (line + 1 < lines.length) {
nextPosition.line = line + 1;
}
}

return nextPosition;
Expand Down
Loading