Skip to content

feat: Add DevContainer and Codespaces support for develop (FrankenPHP) - #486

Draft
Ramjivan wants to merge 2 commits into
BeWelcome:developfrom
Ramjivan:feat/develop-devcontainer
Draft

feat: Add DevContainer and Codespaces support for develop (FrankenPHP)#486
Ramjivan wants to merge 2 commits into
BeWelcome:developfrom
Ramjivan:feat/develop-devcontainer

Conversation

@Ramjivan

@Ramjivan Ramjivan commented Aug 29, 2026

Copy link
Copy Markdown

Following up on the discussion in #484, this PR adds the DevContainer setup for the \develop\ branch (FrankenPHP stack) so it can be tested in parallel with the \ eature/docker-master\ stack (Nginx).

@Neophytis

Copy link
Copy Markdown
Contributor

This PR is fine as a parallel local dev exploration of the FrankenPHP stack — xdebug is correctly placed in bewelcome_php_dev only, the Caddyfile is already on develop, and the words.sql typo fix is welcome.

That said: develop is not deployed anywhere. This is useful for contributors who want to experiment locally with FrankenPHP, but it should stay in draft until there is a deliberate team decision to migrate the production runtime. That decision needs more than a devcontainer — it needs full validation of the rox app under FrankenPHP, nginx removal, and sysadmins-infra changes.

No blocking issues in the diff itself.

@Neophytis
Neophytis marked this pull request as draft September 4, 2026 21:07
@Neophytis

Copy link
Copy Markdown
Contributor

Closing — DevContainer support has been added via #484 targeting feature/docker-master. Thanks Ram!

@Neophytis Neophytis closed this Sep 4, 2026
@Neophytis

Copy link
Copy Markdown
Contributor

Closing this in favour of #484 which has already been merged into feature/docker-master. That PR covers the DevContainer setup we need for the Docker-based development environment. The FrankenPHP approach here is interesting but adds complexity we don't need at this stage — let's keep the stack consistent with what's running on the beta server. Thanks for the contribution Ram!

@thisismeonmounteverest

Copy link
Copy Markdown
Contributor

Reopened. We need to decide if we want to move to FrankenPHP in the future and if that the case the devcontainer is needed.

If we decide not to move the setup needs to be adapted to the one used in master.

The reason I choose FrankenPHP was that the docker stack is prepared for Mercury for push notifications. So I'd rather move.

@Neophytis

Copy link
Copy Markdown
Contributor

Reopened. We need to decide if we want to move to FrankenPHP in the future and if that the case the devcontainer is needed.

If we decide not to move the setup needs to be adapted to the one used in master.

The reason I choose FrankenPHP was that the docker stack is prepared for Mercury for push notifications. So I'd rather move.

It's perfectly fine to evaluate it once Lion is retired. I had closed to not create confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants