feat: Add DevContainer and Codespaces support for develop (FrankenPHP) - #486
feat: Add DevContainer and Codespaces support for develop (FrankenPHP)#486Ramjivan wants to merge 2 commits into
Conversation
|
This PR is fine as a parallel local dev exploration of the FrankenPHP stack — xdebug is correctly placed in That said: No blocking issues in the diff itself. |
|
Closing — DevContainer support has been added via #484 targeting feature/docker-master. Thanks Ram! |
|
Closing this in favour of #484 which has already been merged into |
|
Reopened. We need to decide if we want to move to FrankenPHP in the future and if that the case the devcontainer is needed. If we decide not to move the setup needs to be adapted to the one used in master. The reason I choose FrankenPHP was that the docker stack is prepared for Mercury for push notifications. So I'd rather move. |
It's perfectly fine to evaluate it once Lion is retired. I had closed to not create confusion. |
Following up on the discussion in #484, this PR adds the DevContainer setup for the \develop\ branch (FrankenPHP stack) so it can be tested in parallel with the \eature/docker-master\ stack (Nginx).