Skip to content

[permission_handler_windows] Fix clang-cl compilation #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kataglyphis wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

[permission_handler_windows] Fix clang-cl compilation #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions permission_handler_windows/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.2.3

* Fixes compilation with `clang-cl` (LLVM) by explicitly wrapping the request results map in a `flutter::EncodableValue` before passing it to `result->Success()`.
* Removes an unused `this` capture from the `Geolocator.PositionChanged` lambda, which triggered `-Wunused-lambda-capture`.

## 0.2.2

* Added support for the new Android 17 permission `ACCESS_LOCAL_NETWORK`
Expand Down
2 changes: 1 addition & 1 deletion permission_handler_windows/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: permission_handler_windows
description: Permission plugin for Flutter. This plugin provides the Windows API to request and check permissions.
version: 0.2.2
version: 0.2.3
homepage: https://github.com/baseflow/flutter-permission-handler

flutter:
Expand Down
6 changes: 4 additions & 2 deletions permission_handler_windows/windows/permission_handler_windows_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ void PermissionHandlerWindowsPlugin::RegisterWithRegistrar(

PermissionHandlerWindowsPlugin::PermissionHandlerWindowsPlugin(){
m_positionChangedRevoker = geolocator.PositionChanged(winrt::auto_revoke,
[this](Geolocator const& geolocator, PositionChangedEventArgs e)
[](Geolocator const& geolocator, PositionChangedEventArgs e)
{
});
}
Expand Down Expand Up @@ -139,7 +139,9 @@ void PermissionHandlerWindowsPlugin::HandleMethodCall(
requestResults.insert({EncodableValue(permissions[i]), EncodableValue((int)permissionStatus)});
}

result->Success(requestResults);
// Explicitly wrap the map in an EncodableValue. MSVC accepts the implicit
// conversion, but clang-cl does not and fails to find a matching overload.
result->Success(EncodableValue(requestResults));
} else if (methodName.compare("shouldShowRequestPermissionRationale") == 0
|| methodName.compare("openAppSettings")) {
result->Success(EncodableValue(false));
Expand Down