Skip to content

BAH-5024 | Add Semgrep SAST CI workflow - #69

Open
vishalkarmalkarthoughtworks wants to merge 2 commits into
masterfrom
BAH-5024
Open

BAH-5024 | Add Semgrep SAST CI workflow#69
vishalkarmalkarthoughtworks wants to merge 2 commits into
masterfrom
BAH-5024

Conversation

@vishalkarmalkarthoughtworks

Copy link
Copy Markdown

Summary

Adds .github/workflows/semgrep.yml. Runs Semgrep Community Edition static analysis on PRs, pushes to main/master, and weekly. Findings upload to the Security tab (Code Scanning) via SARIF.

Part of the rollout tracked in BAH-5024, a follow-up to BAH-4795 (same hardened template, applied to repos outside that ticket's original 17-repo scope). Template validated on bahmni-core#330: container image and actions pinned to immutable digests/SHAs, least-privilege checkout (persist-credentials: false), SARIF upload guarded by hashFiles() so the workflow stays non-blocking if Semgrep crashes before producing the SARIF file.

What it catches

OWASP-class bugs: SQL injection, path traversal, XSS, command injection, insecure deserialization. ~2,000 community rules cover the auto-detected language set.

Phase 1 — non-blocking

continue-on-error: true is set so existing findings on legacy code do not fail PRs. Findings still surface in the Security tab for review. A follow-up PR will remove that flag and add --baseline-ref once a baseline is triaged.

Cost: $0

  • Semgrep Community Edition (LGPL-2.1), public registry rules — free for commercial + OSS
  • No SEMGREP_APP_TOKEN, no Semgrep Cloud account
  • GitHub Code Scanning — free for public repos

Test plan

  • Workflow appears in the Actions tab and runs on this PR
  • Scan completes (success or non-zero exit — both are fine in phase 1)
  • SARIF uploads to the Security tab (Code scanning alerts)
  • Subsequent push to the default branch triggers the workflow
  • Weekly schedule appears under Actions → Semgrep SAST

Adds .github/workflows/semgrep.yml. Runs Semgrep Community Edition on PRs, pushes to main/master, and weekly. Phase 1 is non-blocking (continue-on-error: true) while initial findings are triaged. Findings upload to the Security tab via SARIF.

No SEMGREP_APP_TOKEN required; no Semgrep Cloud account.

Pinned to immutable digests/SHAs per the bahmni-core#330 template.
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

GitHub disables a scheduled workflow in a public repo after 60 days with no
repository activity, and the disable applies to the whole workflow, not just
the cron trigger. Bahmni/bahmni-api-test-automation and
Bahmni/openmrs-module-bedmanagement had already lost Semgrep on every PR this
way, and GitHub does not re-enable it when the repo becomes active again.

Scanning on pull_request and on push to the default branch is unchanged, and
workflow_dispatch stays for an on-demand full scan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants