L12: serialize TTY prompts process-wide and share friction accounting#84
Merged
Conversation
- internal/danger/approver.go: add a process-wide mutex (ttyPromptMu) that serializes all TTY approval prompts; move the approval log that drives friction mode to a process-wide map so repeated approvals across tool instances correctly engage high-friction mode. Reset the global log in test mode on each NewTTYApprover so tests stay isolated. - internal/danger/whitebox_coverage_test.go: update record-approval test for the global log. - cmd/odek/parallel_shell_danger_test.go: reset friction state before the trust-cache test. - docs/SECURITY.md + AGENTS.md: document L12 mitigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes L12 (and M-13).
TTYApproverso concurrent CLI tool calls cannot interleave prompts on/dev/tty.NewTTYApproverto keep tests isolated./cc @BackendStack21/odek