Skip to content

test: exclude the overhead benchmark from the coverage job #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muhammetsafak merged 1 commit into from
Oct 3, 2026
Merged

test: exclude the overhead benchmark from the coverage job #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
- name: Install dependencies
run: composer update --prefer-dist --no-interaction --no-progress
- name: Tests with coverage
run: vendor/bin/phpunit --coverage-clover=coverage.xml
run: vendor/bin/phpunit --coverage-clover=coverage.xml --exclude-group benchmark
- name: Enforce coverage gate
run: php bin/check-coverage.php coverage.xml 90

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"scripts": {
"analyse": "phpstan analyse",
"test": "phpunit",
"test:coverage": "phpunit --coverage-clover=coverage.xml",
"test:coverage": "phpunit --coverage-clover=coverage.xml --exclude-group benchmark",
"coverage:check": "php bin/check-coverage.php coverage.xml 90"
},
"config": {
Expand Down
5 changes: 5 additions & 0 deletions tests/OverheadBenchmarkTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

use BabelQueue\Codec\EnvelopeCodec;
use BabelQueue\Contracts\PolyglotJob;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\TestCase;

/**
Expand All @@ -14,7 +15,11 @@
* conservative broker round-trip. Pure CPU — no broker — so the gate is stable and
* environment-independent in CI. The same methodology + reference is used by every
* SDK's equivalent benchmark.
*
* Grouped as `benchmark` so the coverage job (PCOV instrumentation inflates wall-clock
* timings) excludes it; the uninstrumented PHP matrix jobs still enforce the budget.
*/
#[Group('benchmark')]
final class OverheadBenchmarkTest extends TestCase
{
/**
Expand Down
Loading