Beauti logger and clock rate estimation modifications - #6
Open
moverwater wants to merge 3 commits into
Open
Conversation
Added logging for CalibrationDistribution which is removed by 'connect' rules in the BEAUti template.
…estimated when either CalibrationPrior or MRCAPriors are given with a CalibratedCPP model. Disconnects MRCAPriors from tree outputs when switching tree priors so clock rate isn't automatically estimated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set priors for default parameters for CalibratedBirthDeathSkylineModel (turnover and diversificationRate) to be displayed on first build.
Removed code in CalibrationDistributionInputEditor that manually adds MRCAPriors or CalibrationPrior to the loggers. Instead we just log the wrapper CalibrationDistribution which contains either a list of MRCAPriors or the CalibrationPrior.
Created CalibrationClockConnector class that sets the clock rate to be estimated when CalibrationPrior or MRCAPrior is specified with a CalibratedCPP model. It detaches MRCAPrior objects from tree outputs when switching tree priors so the clock rate is not accidentally estimated after switching from a CalibratedCPP tree prior.