Skip to content

Hotfix: Use Native Date Input for Eligibility - #1796

Merged
BrianRamsay merged 4 commits into
developmentfrom
HFeligibilityBug
Aug 25, 2026
Merged

Hotfix: Use Native Date Input for Eligibility#1796
BrianRamsay merged 4 commits into
developmentfrom
HFeligibilityBug

Conversation

@MImran2002

Copy link
Copy Markdown
Contributor

Issue Description

Fixes issue #1795

  • When setting a student as ineligible from their profile, the date field in the eligibility pop-up does not work correctly in Firefox. Users may be unable to select a date, and the current interface also requires use of the calendar picker instead of allowing a date to be typed manually.

Changes

  • Removed reliance on the jQuery UI datepicker for restricting the ban end date.
  • Set the native type="date" input minimum value to tomorrow's date.
  • Calculate the date using the user's local year, month, and day to avoid timezone issues

Testing

  • Checkout to this branch git checkout HFeligibilityBug
  • Pull development git pull origin development
  • Reset database from back-up ./database/reset_database.sh from-backup
  • If you don't have Mozilla download Mozilla Firefox
  • Go to your My Profile and underneath Programs accordion, click the pen next to eligible and choose the date from the date picker or type in the date and that should work.

fritzj2
fritzj2 previously approved these changes Aug 24, 2026

@fritzj2 fritzj2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date box seems to be working on Firefox with this change.
It also seems to continue to work on other browsers like Edge.
The failing tests seem to also be an issue in development so it is not an issue with this PR.

… the input is as the checkvalidity and reportvalidity is use it is adopted in all four broswer Chrome, Edge, Firefox, and Safari. So originally the data is getting correct now we also have cover the edge case of user being able to input old dates
@BrianRamsay
BrianRamsay merged commit 7b66654 into development Aug 25, 2026
0 of 5 checks passed
@BrianRamsay
BrianRamsay deleted the HFeligibilityBug branch August 25, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants